Open
Conversation
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
2 tasks
Contributor
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
Member
ArmandPhilippot
left a comment
ArmandPhilippot
left a comment
There was a problem hiding this comment.
Thank you! I left a few nits/typo fixes but otherwise this looks good to me. Regarding the version, yeah, I'm not sure what is best. I left a comment about that but I don't really have a strong opinion here.
ArmandPhilippot
added
merge-on-release
Member
yanthomasdev
left a comment
yanthomasdev
left a comment
There was a problem hiding this comment.
Thanks @florian-lefebvre, I have a few nits but overall it's looking great!
…ion.mdx Co-authored-by: Armand Philippot <git@armand.philippot.eu>
…ion.mdx Co-authored-by: Armand Philippot <git@armand.philippot.eu>
…ion.mdx Co-authored-by: Armand Philippot <git@armand.philippot.eu>
…ion.mdx Co-authored-by: Armand Philippot <git@armand.philippot.eu>
…ion.mdx Co-authored-by: Armand Philippot <git@armand.philippot.eu>
…ion.mdx Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (required)
svgOptimizerreplacessvgo. Choosing which version to use for theSincecomponent is tricky: SVG optimization exists since 5.16 but the API changes a lot in 6.2. So I decided not to touch itRelated issues & labels (optional)
For Astro version:
6.2. See astro PR #16333.